10 ms·

A change of 84 files and not a single code review comment. Approved and merged! Wow!

zamadatix 5y ago
Looks like he and the guy he had been talking to directly account for ~95% of the line changes over the last 15 years. The next 2 highest account for ~3.5% but haven't been active in years.
buryat 5y ago
LGTM
1vuio0pswjnm7 5y ago
Users should read through the changes before updating https://trac.transmissionbt.com/browser/branches https://trac.transmissionbt.com/browser/branches for pre-2016 https://github.com/transmissionbt https://github.com/transmissionbt from 2016 When we untar the source, the "Changelog" file is empty diff -U0 -r transmission-2.94 transmission-3.00|less Look for compelling reasons to update When statically compiled 2.94, stripped binaries were 3.4M; not too bad Still had to make fixes by hand to get it to compile with musl. These were reported by a musl user on Github years ago. Oh well Need to include bsdqueue.h instead of sys/queue.h in these two files third-party/miniupnp/portlistingparse.h third-party/miniupnp/upnpreplyparse.h Needed to fix some libcurl problem in libtransmission/web.c, too https://trac.transmissionbt.com/ticket/5580 https://trac.transmissionbt.com/ticket/5580 The need for web.c is debatable; "webseed" is not peer-to-peer, who even uses it Wonder if its even worth the effort: https://trac.transmissionbt.com/log/trunk/libtransmission/web.c https://trac.transmissionbt.com/log/trunk/libtransmission/we... "pulling my hair out" 1. https://web.archive.org/web/20111005094923/http://download-origin.transmissionbt.com:80/files/ https://web.archive.org/web/20111005094923/http://download-o... https://web.archive.org/web/20160726015340/http://download-origin.transmissionbt.com:80/files/ https://web.archive.org/web/20160726015340/http://download-o... Might have miscounted but looks something like Year Releases 2006 6 2007 8 2008 19 2009 50 2010 21 2011 10 2012 11 2013 7 2014 2 2015 0 2016 1 + 2017 0 2018 2 + In 2016 started using Github
- 1vuio0pswjnm7 5y ago
  Looks like the sys/queue.h problem got fixed in 3.00 Would be nice if there was a compile-time option to disable the BEP 17 BEP 19 feature

Looks like he and the guy he had been talking to directly account for ~95% of the line changes over the last 15 years. The next 2 highest account for ~3.5% but haven't been active in years.

buryat 5y ago

LGTM

1vuio0pswjnm7 5y ago

Users should read through the changes before updating https://trac.transmissionbt.com/browser/branches https://trac.transmissionbt.com/browser/branches for pre-2016 https://github.com/transmissionbt https://github.com/transmissionbt from 2016 When we untar the source, the "Changelog" file is empty diff -U0 -r transmission-2.94 transmission-3.00|less Look for compelling reasons to update When statically compiled 2.94, stripped binaries were 3.4M; not too bad Still had to make fixes by hand to get it to compile with musl. These were reported by a musl user on Github years ago. Oh well Need to include bsdqueue.h instead of sys/queue.h in these two files third-party/miniupnp/portlistingparse.h third-party/miniupnp/upnpreplyparse.h Needed to fix some libcurl problem in libtransmission/web.c, too https://trac.transmissionbt.com/ticket/5580 https://trac.transmissionbt.com/ticket/5580 The need for web.c is debatable; "webseed" is not peer-to-peer, who even uses it Wonder if its even worth the effort: https://trac.transmissionbt.com/log/trunk/libtransmission/web.c https://trac.transmissionbt.com/log/trunk/libtransmission/we... "pulling my hair out" 1. https://web.archive.org/web/20111005094923/http://download-origin.transmissionbt.com:80/files/ https://web.archive.org/web/20111005094923/http://download-o... https://web.archive.org/web/20160726015340/http://download-origin.transmissionbt.com:80/files/ https://web.archive.org/web/20160726015340/http://download-o... Might have miscounted but looks something like Year Releases 2006 6 2007 8 2008 19 2009 50 2010 21 2011 10 2012 11 2013 7 2014 2 2015 0 2016 1 + 2017 0 2018 2 + In 2016 started using Github

1vuio0pswjnm7 5y ago
Looks like the sys/queue.h problem got fixed in 3.00 Would be nice if there was a compile-time option to disable the BEP 17 BEP 19 feature