4 ms·
> A long time hire with experience on the code base would conduct more of a "feature review". Does the code address the problem or feature correctly? Is the cod
by bluGill 5y ago
> A long time hire with experience on the code base would conduct more of a "feature review". Does the code address the problem or feature correctly? Is the code adhering to feature requirements? These are things that are answered towards the "feature review" of this code reviewing scale.
It is too easy even when you have been there for years to not do that. Feature reviews are hard and boring. You can look at code, but to understand it is hard and takes time. Much easier to just glance at it, hit approve and move one. I catch myself doing that all the time.