2 ms·

These issue numbers are non-portable even within github! Two repositories may have the same commits in them but different sets of issues.

• est31 5y ago
  My favourite is when someone collaborates on a PR and they create PRs for the PR's branch in the forked repo. That repo has its own numbers so you'll end up with merge commits referencing PR #4 in the main repo.
  • tadfisher 5y ago
    Because forks are GUI sugar for refs in the main repo. This is also why Actions have convoluted security implications.
    • est31 5y ago
      No I didn't mean the "you can replace the fork's URL with the main repo one and make the commit seem part of the repo". That's a weird github oddity to keep in mind, but not the issue I meant. I meant when that PR including its merge commits gets merged. Then those commmits become proper members of the main repo.
  • jareklupinski 5y ago
    this came very close to exposing private repo details to the wrong users for me recently currently trying to find an exploit using this 'feature'