4 ms·

You can change what happens when a user hits CMD-w. But CMD-w should still be the trigger. Everyone expects a very specific thing, make the current thing go aw

You can change what happens when a user hits CMD-w. But CMD-w should still be the trigger. Everyone expects a very specific thing, make the current thing go away. Its the same reason you likely picked CMD-k as the shortcut to your pop up window. That's what Slack does along with several other applications. If you want to map this shortcut to your implementation of "going away" that's fine but it should be the same command.

sauravmitra 5y ago
This is a fair point. Right now, it shows a message on the bottom-left asking if you meant to close a page and suggesting "D" as the shortcut instead. I think adding a classic mode with those shortcuts enabled should solve the issue. What do you think?
- verdverm 5y ago
  What happens when a user thinks they are in an input field and hits 'd'? I've experienced the likely same outcome with Vimium and 'x' I suspect you will want to have modifier keys be the default. Something to ask users rather than forcing them to adopt to what you think is best
  - sauravmitra 5y ago
    Hmm, I want to look further into how often this happens. Was this a big issue for you with Vimium? Right now, if you accidentally close a page, you can quickly "Z" (or click the undo button that shows up) to bring the page back.
    - verdverm 5y ago
      I've experienced the loss of input when I habitually hit escape to exit input mode and then x to delete text. (Normal on vim, does not carrier over the same with Vimium) This closes the tab, and on restore, the partial input is lost. Had this hit me more than once on Confluence
      - sauravmitra 5y ago
        Good point. Currently though, if you "z" a page you've closed, it preserves your input. The system isn't perfect, but it prevents any fear of accidental closing.
        verdverm 5y ago
        Can't comment on your browser specifically, just that single key shortcuts which are normal input values is not a good idea. People are used to shortcuts with meta keys proceeding them. It's an established behavior and expectation beyond any one system or tool.
        sauravmitra 5y ago
        Yeah, it's something we thought about a lot before implementing the current system. We think apps like Superhuman have brought the idea of single-key shortcuts into the forefront, and we really like how much more memorable they are for most users. We'll definitely learn from our users' feedback though, and we'll work on a solution with them if they have issues with it :)

sauravmitra 5y ago

This is a fair point. Right now, it shows a message on the bottom-left asking if you meant to close a page and suggesting "D" as the shortcut instead. I think adding a classic mode with those shortcuts enabled should solve the issue. What do you think?

verdverm 5y ago
What happens when a user thinks they are in an input field and hits 'd'? I've experienced the likely same outcome with Vimium and 'x' I suspect you will want to have modifier keys be the default. Something to ask users rather than forcing them to adopt to what you think is best
- sauravmitra 5y ago
  Hmm, I want to look further into how often this happens. Was this a big issue for you with Vimium? Right now, if you accidentally close a page, you can quickly "Z" (or click the undo button that shows up) to bring the page back.
  - verdverm 5y ago
    I've experienced the loss of input when I habitually hit escape to exit input mode and then x to delete text. (Normal on vim, does not carrier over the same with Vimium) This closes the tab, and on restore, the partial input is lost. Had this hit me more than once on Confluence
    - sauravmitra 5y ago
      Good point. Currently though, if you "z" a page you've closed, it preserves your input. The system isn't perfect, but it prevents any fear of accidental closing.
      - verdverm 5y ago
        Can't comment on your browser specifically, just that single key shortcuts which are normal input values is not a good idea. People are used to shortcuts with meta keys proceeding them. It's an established behavior and expectation beyond any one system or tool.
        sauravmitra 5y ago
        Yeah, it's something we thought about a lot before implementing the current system. We think apps like Superhuman have brought the idea of single-key shortcuts into the forefront, and we really like how much more memorable they are for most users. We'll definitely learn from our users' feedback though, and we'll work on a solution with them if they have issues with it :)