3 ms·
Very cool! I hate to be negative, but the typescript is terrible. Full strictness is a must. Once you have that, you will notice why the code is bad: You hav
by geon 5y ago
Very cool!
I hate to be negative, but the typescript is terrible. Full strictness is a must.
Once you have that, you will notice why the code is bad:
You have a kind-property on the class. That tells me there should either be 2 separate classes or (much better) just a tagged union. I don’t see that classes has any benefit in this use case, so I’d just get rid of it.
`ctx` is typed as a Map, but it is used like just a plain hash.
The code is riddled with `any`.
I made a pull request: https://github.com/eatonphil/lisp-rosetta-stone/pull/2 https://github.com/eatonphil/lisp-rosetta-stone/pull/2