4 ms·
I had to review someone's PR for one interview. Ultimately I failed it because me feedback focussed solely on implementation details and asking if there are bet
by ljm 5y ago
I had to review someone's PR for one interview. Ultimately I failed it because me feedback focussed solely on implementation details and asking if there are better ways to solve the problem (with some suggestions as a nudge). Apparently, that was fantastic and showed all the qualities of good coaching...but they expected me to point out all of the instances of poor indentation and other aesthetic things. My justification that it was unimportant and that running rubocop would fix it wasn't good enough - the PR had to know all of the nitpicks.
You know, if I had to do that for every PR I reviewed, I'd be burned out in no time.
It was a shame, but if I didn't flunk that interview then I wouldn't be where I am now.
- dsr_ 5y ago"if I didn't flunk that interview then I wouldn't be where I am now" This is, I think, the closest thing there is to a universal experience in this field. Followed closely by "how did I miss that single-character error?"
- Verdex 5y agoBased on your description ... that wasn't a failure. Success is not working at places like that.