3 ms·
build.sh is broken on my machine (os x, with coreutils installed through homebrew), requires this fix: diff --git a/build.sh b/build.sh index 854aeb6..
by leif 15y ago
build.sh is broken on my machine (os x, with coreutils installed through homebrew), requires this fix:
diff --git a/build.sh b/build.sh
index 854aeb6..4e1c80f 100755
--- a/build.sh
+++ b/build.sh
@@ -2,11 +2,12 @@
include_file() {
f=`echo -n $2 | sed 's/\//\\\\\//g'`
- tmp=`mktemp`
+ tmp=`mktemp helloXXXXXX`
cat "$2" | gzip | base64 > "$tmp"
cat "$1" | sed "/#INCLUDE:$f#/ {
r $tmp
- d }"
+ d
+ }"
rm "$tmp"
}
- p4bl0 15y agoIt's really sad that even those small utils are not perfectly compatible from one platform to another. The `mktemp` from GNU coreutils don't require the model :-(. Luckily the changes you suggest seems to also work with the GNU coreutils, so I'll apply them everywhere (there's a lot of call to mktemp and another similar sed call in the hooks). Thanks :-). Edit: It's done, I credited you as the author of the commit (see here: http://gitorious.org/fugitive/fugitive/commit/006260555956124bf11997e59dca4ee9e1351841 http://gitorious.org/fugitive/fugitive/commit/00626055595612...).
- leif 15y agoYeah, you really have to read the posix specs carefully to catch all these bizarre inconsistencies (or, if you're like me, wait until you find a system something breaks on and then fix it). It's a shame. Thanks :) I'd have sent you a merge request but I don't have a gitorious account.