6 ms·
glibc's abort() is even more complex: http://sourceware.org/git/?p=glibc.git;a=blob;f=stdlib/abort.c;h=e9d0ab18fd7d05e3d7016d03794438ccd1e141d6;hb=HEAD http://
by KonradKlause 15y ago
glibc's abort() is even more complex:
http://sourceware.org/git/?p=glibc.git;a=blob;f=stdlib/abort.c;h=e9d0ab18fd7d05e3d7016d03794438ccd1e141d6;hb=HEAD http://sourceware.org/git/?p=glibc.git;a=blob;f=stdlib/abort...
- jordanb 15y agoMost of the code in glibc has been heavily Dreppered.
- KonradKlause 15y agovery true. but glibc's abort() is IMHO ok.
- ars 15y agoWhat does Dreppered mean?
- pluies 15y agoIt's probably a quip referring to Ulrich Drepper, a kernel hacker whose personality seems to be quite controversial according to a quick Google search. I'd love to hear the GP explain it further though.
- VMG 15y agoIs he a kernel hacker? I thought he was only a glibc hacker.
- drv 15y agoUlrich Drepper is the maintainer of glibc; I don't know what the comment is intended to mean, though.
- jordanb 15y agoUlrich Drepper tends to write software that is easy for him to read (one would hope) -- but is very difficult for anyone else to follow.
- jrockway 15y agoBut you have to admit, his abort is pretty damn easy to read.
- jordanb 15y agoI admit it's heavily commented, and his usual tangle of preprocessor macros are blissfully absent. But it contains hints of Drepperification, like the superfluous use of preincrement.
- kelnos 15y agoWhen I don't care about the result, I always write preinc/decrement too. Sure, it's superfluous on any non-braindead compiler (it should be able to see that you don't care about the result of a postincrement and elide the temporary), but it's just habit at this point. I fail to see how it reduces or changes readability though. Sounds like you just have an axe to grind with Drepper.
- jordanb 15y agoI don't have anything personal against Drepper. I've never had any direct experience with him of any kind. I thoroughly enjoyed his article about memory. He is obviously an extremely intelligent and knowledgeable guy. I am afraid that he is too clever by half though, insofar as good code is clean and readable first, and clever second. Every time I've had an opportunity to interact with the glibc codebase I'm dismayed that such an important, core piece of software has been written so cleverly that it essentially can only be maintained by one guy.
- kelnos 15y agoThat's unfortunate; I'll have to look at some glibc code sometime. Could be fun... or, as you point out, dismaying :-/