2 ms·
We will not submit a change that's not been reviewed, meaning that everyone does multiple reviewss per day. While it may not catch all the bugs (it will catch m
by dusted 5y ago
We will not submit a change that's not been reviewed, meaning that everyone does multiple reviewss per day.
While it may not catch all the bugs (it will catch most of the typos though) it does help the style and readability a lot, it makes everyone more familiar with the codebase and it often presents learning opportunities for everyone.
It was a bit intimidating at first, being the new guy, and at first I would read through things and mostly say "+1, I can't find any obvious fault with this", and gradually, I became confident enough to start asking questions, and started to catch logic errors and uncover edge-cases. But boy do I ask a lot of questions that have some trivial answer that I just didn't know.. Learning not to care if others think you're ignorant, or maybe, accepting that to some degree, everyone are.. Was key for me to get more out of reviewing.