3 ms·
The two senior devs I report to routinely: - Approve one another's PRs (which are either 1 or 2 line things, or 2000 line behemoths. Never in between) without
by dkdbejwi383 5y ago
The two senior devs I report to routinely:
- Approve one another's PRs (which are either 1 or 2 line things, or 2000 line behemoths. Never in between) without a review, or approve ignoring comments left by others
- Just comment out tests that won't pass because of a change they made, rather than fix it
- Because of the first point, sloppy mistakes and debug stuff (print statements) gets left in the codebase
- Follow poor code health practices, like disabling deprecation warnings instead of updating deprecated code
Whereas most of the mid & junior level devs in the team spend time writing tests, suggest new test cases for one another in PRs, discuss clarity of syntax, try to keep their changes minimal and understandable.
I'm only really sticking around at this point until the pandemic situation has calmed down a bit more, and because I don't want to have too many short experiences on my CV.