4 ms·

How to x articles usually annoy me, but I think this was great advice. And not just for junior developers

• another-dave 5y ago
  Agreed. I wish a lot more so-called senior developers would start their critique with "Why did you do X?" rather than "You should've done Y". Sure, if there's an obvious error it's good to just go ahead & point it out, but you're often landed with the negative criticism first, simply because your colleague didn't understand the problem space enough. Your code might still need work since they didn't — e.g. better naming/test cases/comments — but it sets a completely different tone.