3 ms·
This is why your project should be set up so these kind of checks can be performed easily and quickly locally. We auto format on compile for example. Enforcing
by spockz 5y ago
This is why your project should be set up so these kind of checks can be performed easily and quickly locally. We auto format on compile for example.
Enforcing code style is not nonsense when automated. It ensures consistency and it helps preventing things like changes in white space without any semantic change.
Manual checking of the above is silly indeed. Review comments should be about the code and intent. Not the syntax.
- patrick451 5y agoThe biggest reason to use an auto formatter is take all those nits off the table for gripes during code review. I think the consistency claim is overrated. Seeing ){ vs ) { doesn't help me read a codebase better, not does see un-alphabetized imports. The biggest culprit of whitespace only changes is somebody running an auto-formatter on a file where that isn't enforced by CI.