5 ms·
Hey, just wanted to tell you that the code you have currently doesn't compile. `SentryHelper.h` is required for `ADD_EXCEPTION_CONTEXT` macro, which can be emp
by m1el 5y ago
Hey, just wanted to tell you that the code you have currently doesn't compile.
`SentryHelper.h` is required for `ADD_EXCEPTION_CONTEXT` macro, which can be empty.
`HelpMenus.cpp` has a syntax error in preprocessor directives and an extra comma.
- cookiengineer 5y agoHey, thanks for the hint :) I thought I amended those changes to the latest commit, but I seem to have forgotten to push those fixes. Originally I just injected the macro via command line as it didn't do anything when reporting was disabled. Can you please confirm that your HEAD contains the ":bug: Fixes" commit? [1] - I'll upload the built Arch package to the GitHub releases as soon as it's built again. I was using the "audacity-git" [2] AUR package's PKGBUILD file (replaced repo URL with my one) to generate my package and it seemed to work without issues with those fixes applied. There was also a "pthread_cleanup_pop(1)" patch in the PKGBUILD for the alsa library which I wondered about why it hasn't been pull requested upstream...but no idea what's up with that tbh. [1] https://github.com/cookiengineer/audacity/commit/d9f30b2b729becf7f3810b32c5b55f3886687e63 https://github.com/cookiengineer/audacity/commit/d9f30b2b729... [2] https://aur.archlinux.org/packages/audacity-git/ https://aur.archlinux.org/packages/audacity-git/
- m1el 5y agoYes, it does build.