3 ms·
> git and Linux practice only commit-level review. I don’t think that’s an accurate way to put it. AFAIK you just send in patch files. They create a single com
by fuzzy2 5y ago
> git and Linux practice only commit-level review.
I don’t think that’s an accurate way to put it. AFAIK you just send in patch files. They create a single commit, yes, but I see it as equivalent to a PR. The rules of what can be in a single patch could be stricter than typical PRs on other projects, dunno.
> Commit history is just as subject to review as the contents of diffs.
I wish. Maybe I’ll work on a better team on the future.
- juped 5y agowhat I mean is, take any arbitrary patch thread off the front page of https://public-inbox.org/git/ https://public-inbox.org/git/ and look at how people review them. they reply to the relevant commit. if you reply to the cover letter it's not a code review at all, but a more general comment on the whole branch (e.g., "do we want this feature" or something). you definitely don't send your branch as a single patch (unless it is small and really is best expressed as a single patch). if you did you would be asked to break it up.