7 ms·
Audacity now has quite a bit of networking code. Some of the more interesting parts involve something called "Sentry". Code for that went in 26 days ago.[1] I'm
by Animats 5y ago
Audacity now has quite a bit of networking code. Some of the more interesting parts involve something called "Sentry". Code for that went in 26 days ago.[1] I'm not sure when this runs, but there is code here [2] to read the contents of the URL
https://sentry.io/get-cli/ https://sentry.io/get-cli/
and feed it into the bash shell. Whomever controls that URL can download anything they want.
This supposedly is for crash reporting.
Whether this is a security problem I will leave to others.
[1] https://github.com/audacity/audacity/blob/97914403f61cfebf6f3c87d084dc1a5e5d5eac7d/libraries/lib-sentry-reporting/SentryRequestBuilder.cpp https://github.com/audacity/audacity/blob/97914403f61cfebf6f...
[2] https://github.com/audacity/audacity/blob/2e0e3b4162c8e4ab3dab1f0ca0494b0acf024e8e/scripts/ci/upload_debug_symbols.sh https://github.com/audacity/audacity/blob/2e0e3b4162c8e4ab3d...
- javajosh 5y agoYou beat me to it! But I doubt Sentry is the vector - it's a generally legitimate service that helps software devs track failures in the wild without the users having to report anything - I've worked with it for single page web applications. Of course, it could be abused to track anything. The right short-term thing to do is deny it networking access with LittleSnitch (mac) or the equivalent, while buying time to produce a privacy-preserving fork. FWIW, I don't think Sentry is appropriate for this kind of application. OSS should have opt-in error reporting only. It would also be a good opportunity for the fork to factor out the UI into something like Electron, because the Audacity UI has always been pretty bad, IMHO. (I suspect the biggest obstacle to producing a viable fork will be fights over which pun to use as a replacement name.)
- sneak 5y agoIt's not legitimate because it happens without the consent of the user. It transmits their data without ever asking them if they want to be spied on.
- iakov 5y agoIt's not Sentry's job to ask users for consent, but the software developers. If you want to be mad - be mad at the people who are doing the truly shitty things with your data, not at the legitimate vendor.
- sneak 5y agoWhat percentage of Sentry's customers are collecting the data unethically? At some point the tool vendors share responsibility. It's like saying it's not AdWords or Facebook's fault there are so many ads everywhere, because it's the people who pay to run the ads who are at fault.
- Griffinsauce 5y ago> OSS should have opt-in error reporting only. I'm curious what's different about OSS in this regard? I thought this was an argument about the user's privacy, so what does it matter how the software was built? Also a sidenote: this whole thread feels quite pedantic and counterproductive to me. Sentry is an error reporting tool that helps solve issues in software, the alternative is your software having many, many more bugs that never get fixed. It's not used for tracking or "spying". I feel that blowing your stack about a tool like this weakens your argument against true privacy invasions. It trains people to stop listening because we whine about things that are not actually a problem.
- dgan 5y agoWhen you need to report errors from offline product, you create a dump file, zip it, and ask user to send it if he wants the problem investigated File creation can be done automatically as a segfault handler for example
- yarcob 5y agoI have some experience developing desktop apps. Less than 1% of crashes are reported by users. And only around 50% of users who do report a bug will provide follow up info such as crash reports or diagnostic information. Before I had automatic crash reporting, I was blissfully unaware how bad my app was.
- dgan 5y agoWell what you said is correct, but there is a difference between a commercial product, and free software I would expect users to care more about the latter. For example, I am specifically talking about open source games, where often users report errors with zipped stacktrace attached
- duckmysick 5y agoIn my experience it's the other way around - but the difference is not that big anyway. Commercial programs typically imply paid support, which can tease out more details when the user contacts them. The users themselves are also more invested, as they already committed their money. Open source software faces the same problems about a lack of bug reports. Check out this article and the related HN discussion: https://pointersgonewild.com/2019/11/02/they-might-never-tell-you-its-broken/ https://pointersgonewild.com/2019/11/02/they-might-never-tel... https://news.ycombinator.com/item?id=21427996 https://news.ycombinator.com/item?id=21427996
- swiley 5y ago>it's a generally legitimate service Opt-out network access or reporting of anything is never legitimate.
- aspaceman 5y agoIt's opt in.
- WesolyKubeczek 5y agoWait, what, instead of using Sentry Native SDK, they are doing this? Lame. Laaaaaame.
- deleted 5y ago[deleted]
- fmajid 5y agoSentry is a crash/error reporting system, not sinister in itself.
- fencepost 5y agoHuh. Downloads and executes shell code you say? Wonder how the security on their site and DNS are.
- ylyn 5y agoIt's under a folder called "scripts/ci". All the script does is upload debug symbols to Sentry so that it can decipher crash traces. When exactly do you think it is run?
- zeeg 5y agoReading this thread I was surprised about the amount of conjecture when someone could literally just read the source - or read your comment - to know precisely what the intent is. This is entirely correct. The `sentry-cli` binary is primarily used to achieve two things: 1) to upload commit metadata, so that its easier to trace a problem to the commit graph 2) to upload debug symbols (or similar), so that Sentry can turn machine data into something human readable, again to make it easier to diagnose issues
- DyslexicAtheist 5y agoSentry is a poorly designed crash reporting service that can be a massive vector for supply chain attacks. E.g. a sentry crash report makes an interesting target since it can save an adversary a lot of time finding exploitable parts of an application. Sentry claim that github and Disney is using their service ("among many other fortune-500 companies"). The problem isn't so much that there are potential security holes in sentry but that a service like Sentry should never be a SaaS (or if it is should come with a massive disclaimer - but since they just raised 69 MM last year and want to be seen as the github of crash-reports they're not gonna talk about it). Outsourcing something like that and sending it over the network demands a huge amount of trust. One might say that Anti-Virus companies or certificate authorities demand the same, so where is the problem? The problem is that nobody raised this (yet) so they don't even position themselves as a service that ought to take security seriously. There is also the elephant in the room of how many Sentry employees get to see the crash reports of these companies, what security clearance they have and how well they're vetted. Scrubbing of PII in the crashes is left to the client using the service and it often happens that PII still leaks anyhow. Whoops! Ignoring all this for a moment, Sentry also has other problems limiting its usability: it can't be isolated from the main application logic and its ability to be useful is affected during times of a crash (when crash reporting is actually needed most). The correct approach to do something in the observability space today would be to make it live inside a eBPF VM (and not have the crash reporter run in the same context as the application). Edit: The (genius) growth-hacking and business model of sentry is to convince companies that it provides value by creating a dependency of Sentry API calls in their clients application code. This is hard to pull off but once a customer has been convinced that making sentry.io calls is useful, they're basically joined at the hip. This is what makes them a highly valued company (from a financial pov) since getting rid of it is as much effort (and even potential risk) as putting it in place.
- viraptor 5y ago> a service like Sentry should never be a SaaS Unless you can see their private config, we don't know where SENTRY_DSN_KEY is pointing. You can host sentry yourself. (https://develop.sentry.dev/self-hosted/ https://develop.sentry.dev/self-hosted/) I get you're worried about crash reports being shared, but that warrants a big "if they're using the hosted version" qualifier.
- ThePadawan 5y agoYou're referencing a bash script that is run during the Github CI build: https://github.com/audacity/audacity/blob/407be925e5226ddb49441f2815e1ff19e11df57c/.github/workflows/cmake_build.yml https://github.com/audacity/audacity/blob/407be925e5226ddb49... This is not for crash reporting.
- viraptor 5y agoI'm not sure why you say it's not for crash reporting. Sentry can be used both is CI and in the distributed application.
- orf 5y ago> I'm not sure why you say it's not for crash reporting. Because, as the comment you’re replying to said, that bash script is only used in the CI process. That’s also completely obvious from only a cursory glance at the script itself.
- viraptor 5y agoBut it can be used for error/crash reporting in CI.
- orf 5y agoNo, it cant. Read the damn file you linked. It’s a script that uploads release files to Sentry so it can be used while correlating crash reports, when a release is made. And nobody in their right mind would ever send crash reports to Sentry from a CI. That’s completely nonsensical.
- ljm 5y agoIt would be an expensive way to report on a test suite, I'll give you that.
- viraptor 5y agoIt depends on what you're trying to achieve. It's totally reasonable to report stack traces from the CI, especially from the master branch for a quick overview on flakey tests. I don't know anything about their setup specifically, but that approach does have use cases.
- matheusmoreira 5y agoSo it's piping code from the network directly into our shells. What the fuck! This thing has a literal backdoor into our machines!
- bb010g 5y agoThat script is a utility for continuous integration, not anything distributed with Audacity.
- deleted 5y ago[deleted]
- swiley 5y agoThey just dumped RCE into an open source project. Audacity is dead. Hopefully the devs move to one of the forks and it has a good name.