3 ms·
Here's a contrived example... Let's say a PR arrived that appeared to create a new S3 bucket and a new IAM role with an attached policy that grants read-only pe
by clipradiowallet 5y ago
Here's a contrived example... Let's say a PR arrived that appeared to create a new S3 bucket and a new IAM role with an attached policy that grants read-only permissions to that bucket.
The old me would read it, and write something like "adds S3 bucket and IAM role".
The newer me would write it as:
1. Creates S3 bucket <XYZ> in account <DEF>.
2. Creates IAM role <ABC>, with an attached policy granting read-only access to S3 bucket <XYZ>.
It seems like a small change, but when I'm actually planning to type out those details - I'm more likely to notice typos in the name/account/role/etc, or just outright errors. One of the mental shifts from my old reviews to newer ones is that I open the PR assuming I don't know what it does yet. So I have to read it for myself and interpret it, then summarize it for someone else.
- cbsmith 5y agoThanks, this helped clarify for me what your experience was like. It's interesting.