4 ms·
In probably most cases the person who does the code changes does write tests for it as well. So as a reviewer without understanding what the code and the tests
by Dunedan 5y ago
In probably most cases the person who does the code changes does write tests for it as well. So as a reviewer without understanding what the code and the tests do, how do you want to assess if the tests actually do something useful?
- QuercusMax 5y agoIf your code and tests are so opaque that the reviewer can't understand them without physically running and modifying the code, then as a reviewer you should ask the author to make it clearer. Because otherwise that's how you get write-only code. Things like code style and documentation can make a big difference, and review time is when you can help enforce them and build team culture and knowledge.