5 ms·
That's interesting to consider a code walkthrough as different than a code review. How would you describe the differences? To me code reviews can catch style a
by cbsmith 5y ago
That's interesting to consider a code walkthrough as different than a code review. How would you describe the differences?
To me code reviews can catch style and functional problems in code that get by your automation systems, but the primary impact of a code review is on the team, not the code. It imparts not just an understanding and ownership of the code, but also establishes/negotiates how the team works together.
- miltondts 5y ago> That's interesting to consider a code walkthrough as different than a code review. How would you describe the differences? The code review process I'm familiar with is: open a PR, wait for a couple of reviewers to comment on the work. Then normally what happens is: - The comments are trivial, so I implement the changes (these are almost always things that could be automated, but for one reason or another haven't been). - The comments need to be discussed/clarified, so I need to call the person. The code by itself doesn't have all the context, all the things that were tried etc. A code walkthrough is a session with other coders, where it is explained how and why we arrived at the solution, what considerations were made and so on. Walkthrough sessions provide much faster feedback and all improvements can be discussed immediately with much greater clarity.
- cbsmith 5y agoGot it. So for my semantics, your review process for PR's sucks, lacking engagement, and you have to have meetings to get it done right.