2 ms·
While we don't often look at it that way, each PR has a cost associated with it. If its job code and I spend an hour going over the changes, that's an hour of c
by shagie 5y ago
While we don't often look at it that way, each PR has a cost associated with it. If its job code and I spend an hour going over the changes, that's an hour of cost and the org is aware that reviewing PRs is part of my responsibilities and I get paid for that.
For open source projects, when someone submits a PR, that cost of time is done by volunteers. For larger projects, reviewing even a "trivial" PR could incur a few hours of work by the reviewers and maintainers. For a non-trivial PR, this is even more of an investment of time by the maintainers.
I'm not trying to say "don't contribute" but rather "be mindful of other people's time."
The "students should contribute to open source projects" and similar "have a class go and contribute to Wikipedia" or "have a class ask and answer Stack Overflow questions" pushes the responsibility of reviewing that material out to volunteers.
The costs of Hacktoberfest and similar "contribute to open source" as a KPI for some organizations are very hard to calculate - but they're there and should not be ignored. This cost is increased when the person is doing it as a one off contribution rather than ongoing as, again, the costs of onboarding the contributor to the workflow for the project is borne by volunteers.