4 ms·

When people make trivial typo PRs on my open source projects I say thanks very much, close their PR, and make the change in a commit under my name. This way, if

When people make trivial typo PRs on my open source projects I say thanks very much, close their PR, and make the change in a commit under my name. This way, if their interest is in improving the project then it worked. And if their interest is in contributions then it works also because it doesn't pollute their contribution history with trivial changes that aren't real contributions.

theli0nheart 5y ago
That’s incredibly disrespectful. With that approach, I would be shocked if anyone would want to contribute to your project again after such behavior.
- gxnxcxcx 5y ago
  Maybe it's easy to feel it's disrespectful because they've made social networks out of contributing to repositories. Accreditation for the modification of petty and trivial issues is a nice and decent gesture, but overall unworthy of a paper trail binding me to any random none-of-my-business project for such a drive-by PR. Personally, I would feel more comfortable sending that kind of inane PRs if the parent's way of merging was the standard one, but I know it isn't and therefore opt to keep separate accounts to compartmentalize (which unfortunately increases friction to such contributions).
  - theli0nheart 5y ago
    > Accreditation for the modification of petty and trivial issues is a nice and decent gesture, but overall unworthy of a paper trail binding me to any random none-of-my-business project for such a drive-by PR. I don't know about others, but before investing significant time in a project, my first action will be to read through the documentation, then the code (and accompanying comments), and then I'll make minor fixes along the way. After this, I'll submit a PR with my changes. If a maintainer were to close my patch and then proceed to commit the exact same changes under their own name, I'd never contribute, use, or improve that project again. Why would I waste my time? That kind of behavior displays an immense lack of respect for contributors.
    - da39a3ee 5y ago
      I was referring to a PR which literally changed a single letter :) Not a meaningful piece of proof-reading work.
- da39a3ee 5y ago
  Sorry, you missed my point. I'm talking about people who tour around GitHub making PRs comprising a single letter typo charge in order to bolster their contribution statistics. For example the last one I got was changing Github to GitHub in one location. I have no time for that whatsoever. I'm otherwise an extremely friendly and respectful maintainer, including with beginners, of course, and my project has various repeat contributors; I'm sorry I can't point you to it to convince you of that. Your comment is a misjudgment.

theli0nheart 5y ago

That’s incredibly disrespectful. With that approach, I would be shocked if anyone would want to contribute to your project again after such behavior.

gxnxcxcx 5y ago
Maybe it's easy to feel it's disrespectful because they've made social networks out of contributing to repositories. Accreditation for the modification of petty and trivial issues is a nice and decent gesture, but overall unworthy of a paper trail binding me to any random none-of-my-business project for such a drive-by PR. Personally, I would feel more comfortable sending that kind of inane PRs if the parent's way of merging was the standard one, but I know it isn't and therefore opt to keep separate accounts to compartmentalize (which unfortunately increases friction to such contributions).
- theli0nheart 5y ago
  > Accreditation for the modification of petty and trivial issues is a nice and decent gesture, but overall unworthy of a paper trail binding me to any random none-of-my-business project for such a drive-by PR. I don't know about others, but before investing significant time in a project, my first action will be to read through the documentation, then the code (and accompanying comments), and then I'll make minor fixes along the way. After this, I'll submit a PR with my changes. If a maintainer were to close my patch and then proceed to commit the exact same changes under their own name, I'd never contribute, use, or improve that project again. Why would I waste my time? That kind of behavior displays an immense lack of respect for contributors.
  - da39a3ee 5y ago
    I was referring to a PR which literally changed a single letter :) Not a meaningful piece of proof-reading work.
da39a3ee 5y ago
Sorry, you missed my point. I'm talking about people who tour around GitHub making PRs comprising a single letter typo charge in order to bolster their contribution statistics. For example the last one I got was changing Github to GitHub in one location. I have no time for that whatsoever. I'm otherwise an extremely friendly and respectful maintainer, including with beginners, of course, and my project has various repeat contributors; I'm sorry I can't point you to it to convince you of that. Your comment is a misjudgment.