2 ms·
Hi Leizhen, and guys in the mail list, Recently I find one patch removing a debug OOM error message from btrfs selftest. It's nothing special, some small clea
by zeusk 5y ago
Hi Leizhen, and guys in the mail list,
Recently I find one patch removing a debug OOM error message from btrfs selftest.
It's nothing special, some small cleanup work from some kernel newbie.
But the mail address makes me cautious, "@huawei.com".
The last time we got some similar patches from the same company, doing something harmless "cleanup". But those "fixes" are also useless.
This makes me wonder, what is really going on here.
After some quick search, more and more oom error message "cleanup" patches just show up, even some misspell fixes.
It's OK for first-time/student developers to submit such patches, and I really hope such patches would make them become a long term contributor.
In fact, I started my kernel contribution exactly by doing such "cleanups".
But what you guys are doing is really KPI grabbing, I have already see several maintainers arguing with you on such "cleanups", and you're always defending yourself to try to get those patches merged.
You're sending the patch representing your company, by doing this you're really just damaging the already broken reputation.
Please stop this KPI grabbing behavior, and do real contribution to fix the damaged reputation.
^^ Original message
Not sure where he said it'd be okay if anyone else sent it - but I can see why a string of "cleanup" from a company can be seen as more as metric manipulation than any actual worthwhile contribution.
- dang 5y agoCan you please not copy the entire OP like that? It's confusing, obscures your specific point, and leads other commenters to reply to random things in the OP, which is fine of course, but that's what the thread is for in the first place. We detached this comment from https://news.ycombinator.com/item?id=27630257 https://news.ycombinator.com/item?id=27630257.
- zeusk 5y agoWell the reply was to a comment that didn't seem to have read the link so I felt it was apt but alright.