5 ms·

It's not about security. It's about wasting reviewers' time. I too would be annoyed if someone was submitting, say, whitespace-only changes, or similar cleanup,

by ridaj 5y ago

It's not about security. It's about wasting reviewers' time. I too would be annoyed if someone was submitting, say, whitespace-only changes, or similar cleanup, non-functional changes - I still have to review them and my time would be better spent looking at actually meaningful changes that make the product better. It's OK if someone is just learning the ropes with an easy change, but this seems to be more like people trying to game a metric by submitting lots of small changes, which wastes the reviewers' time for no actual user benefit.

bombcar 5y ago
I think the proper way to do a “cleanup” patchset is to communicate with the maintainer beforehand and ask them what they’d prefer
- Cthulhu_ 5y ago
  Or as the maintainer themselves have indicated, bundling a number of these changes together along with a cover letter explaining them.
  - powerapple 5y ago
    Would you rather spend 5 minutes to read a cover letter and code, or just read the diff see word_a has been changed to word_b in comments? Trivial typo or cosmetic changes should stay small, and can be approved in a few seconds.
deleted 5y ago
[deleted]
41209 5y ago
I think there was some medium post by a guru where he claimed the best way to get experience was to submit as many spelling error pull request as possible. That way he can throw in his resume that he's contributed to a dozen or so open source projects. Given how broken the hiring process is, it wouldn't surprise me if this works
- MR4D 5y ago
  Ugh. Next thing we’ll see is a LinkedIn widget on your profile page showing how many projects you’ve committed to. I know GitHub does something like this already, but GitHub is more techie sharing, and LinkedIn is more about bragging based o what I see.
- tablespoon 5y ago
  That sounds more like fabricating experience than getting experience.
treesknees 5y ago
There is a certain balance to this however. Where I work we generally have a rule of no formatting changes mixed in with real code changes to make reviewing easier. It's a huge pain to see a ton of white space fixes mixed in with logic changes. As long as they're separate commits in the same pull request it's usually OK. We also generally don't have formatting-only pull requests because it just adds overhead and indirection to git-blame, and doesn't add value to the end product.

by ridaj 5y ago

bombcar 5y ago

I think the proper way to do a “cleanup” patchset is to communicate with the maintainer beforehand and ask them what they’d prefer

Cthulhu_ 5y ago
Or as the maintainer themselves have indicated, bundling a number of these changes together along with a cover letter explaining them.
- powerapple 5y ago
  Would you rather spend 5 minutes to read a cover letter and code, or just read the diff see word_a has been changed to word_b in comments? Trivial typo or cosmetic changes should stay small, and can be approved in a few seconds.

deleted 5y ago

[deleted]

41209 5y ago

I think there was some medium post by a guru where he claimed the best way to get experience was to submit as many spelling error pull request as possible. That way he can throw in his resume that he's contributed to a dozen or so open source projects. Given how broken the hiring process is, it wouldn't surprise me if this works

MR4D 5y ago
Ugh. Next thing we’ll see is a LinkedIn widget on your profile page showing how many projects you’ve committed to. I know GitHub does something like this already, but GitHub is more techie sharing, and LinkedIn is more about bragging based o what I see.
tablespoon 5y ago
That sounds more like fabricating experience than getting experience.

treesknees 5y ago

There is a certain balance to this however. Where I work we generally have a rule of no formatting changes mixed in with real code changes to make reviewing easier. It's a huge pain to see a ton of white space fixes mixed in with logic changes. As long as they're separate commits in the same pull request it's usually OK. We also generally don't have formatting-only pull requests because it just adds overhead and indirection to git-blame, and doesn't add value to the end product.