4 ms·
I've worked in a place that didn't do code reviews. The argument here was that you're supposed to think about every case and ask questions even for what seems t
by ManlyBread 5y ago
I've worked in a place that didn't do code reviews. The argument here was that you're supposed to think about every case and ask questions even for what seems to be a trivial matter. That was the "official" explanation, the reality was that the boss was dumb enough to claim that "we don't have time and the client doesn't pay us for code reviews". This has continously lead to more bugs and comments like "what is this, why is this code here, who did it this way, it makes no sense". It also turned deployment into a nightmare since there always had to be at least two people on standby in case some piece of code starts wrecking havoc in production.
I have managed to successfully convince the people working there to change the approach by forgetting a WHERE clausule in an SQL script which has caused havoc in the production system and forced several people to work at night and on the weekend. No one has caught it in testing because the change - despite the severity - was tested by a very inexperienced person and the testing environment has almost no data in the database so no one noticed the problem at this stage.
I don't feel bad at all about this because the change was big and I actually asked for review (even though we had no such process) and I was ignored. It also wasn't the first time something like this was happening at that company, it was like that for years. The havoc could be even worse if I made a similar mistake somewhere else in the script, it would take weeks to clean up the mess and it would no doubt cause a huge financial loss for the client.
There were some people who actually quit that company over the lack of such oversight and so did I. I think it's an important failsafe mechanism, no less valuable than unit tests for example.
- nsonha 5y agoI'll give no CR with other strong engineering practices the benefit of doubt, but from story it's likely no review no automated tests which sounds like hell.
- ManlyBread 5y agoYeah, any automatic tests were optional and took ages to execute due to the technologies and approaches used. Running around 1k tests on Ryzen 3700X was taking around 30 minutes.