4 ms·
I'm making the case against making code reviews optional by relating my experience that there's a significant benefit to someone taking a quick glance when they
by jrumbut 5y ago
I'm making the case against making code reviews optional by relating my experience that there's a significant benefit to someone taking a quick glance when they don't have the time/inclination to do a thorough review.
I'm talking about less than a minute in many cases, a sanity check, because eventually someone will slip and commit debugging code that reveals sensitive information, outputs ":wq" in the header of every page, or something else that will be obvious to anyone who isn't the original author. Catching one of these before release is going to be worth doing hundreds of little reviews and a lot of pretty good automated test suites won't catch these kinds of bugs.