4 ms·
I’m an experienced programmer and I hope a pretty good one. At least I’m paid that way so maybe it’s true. I make mistakes. Sometimes there’s a typo. I sometim
by Nursie 5y ago
I’m an experienced programmer and I hope a pretty good one. At least I’m paid that way so maybe it’s true.
I make mistakes. Sometimes there’s a typo. I sometimes miss that there was already a utility function that basically does that. Sometimes another engineer knows a better way to achieve the same thing. Sometimes I left in something unnecessary and missed it when I reviewed the changes.
I like having eyes on my code because it gives me reassurance and occasionally I learn things. It’s not an issue of trust.
- postalrat 5y agoEveryone should be free to request reviews by default if they wish.
- thomaspaulmann 5y agoThat‘s the point. Everybody can, we just don‘t require it. Leaving it up to the individual developer to decide when it‘s right.
- Nursie 5y agoThen IMHO you're likely to get an odd culture of people requesting reviews or not based on perceived urgency, and also you're likely catering to those who consider it a point of pride not to need them, which is not a good attitude. We don't insist on review because we don't trust people, we insist on it because it catches problems, spreads knowledge around and helps developers.
- postalrat 5y agoIMO the biggest advantage for not requiring code reviews for every change is to concentrate code review efforts to where it's needed most: changes with higher risk. Sure, every change has some degree of risk. But obviously some changes have more and if you are treating all changes equally then you may overlook the important changes.
- Nursie 5y agoI'm not sure that requiring a review implies treating all changes equally, but it does at least get some eyes on everything, and IMHO that's important.
- schwartzworld 5y agoSo only the conscientious devs get code reviews. Great.