4 ms·
Yet another reason why C was a mistake.
by bitwize 5y ago
Yet another reason why C was a mistake.
- m45t3r 5y agoParsing unstruted strings without escaping special characters is an issue in any language. This is completely Apple's fault.
- plantain 5y agoFunny how these faults keep happening over and over again in the same set of languages.
- m45t3r 5y agoI am pretty sure that I can have injection attacks from unsanatized user inputs in any language.
- melff 5y agoYes, but some languages (like my personal favorite Rust) make it practically impossible to happen with their equivalent of printf().
- dmitrygr 5y agoFunny how most car crashes are caused by humans driving.
- dylan604 5y agoWe've all been trained to sanitize user input, but the WiFi SSID isn't a user input string, so why should I need to sanitize it? --some poor dev wondering where their Twitterverse sympathy is
- scintill76 5y agoIn a better language than C, format string injection would be less likely to lead to arbitrary read/write/RCE. I'll admit I looked around before writing this and saw that Python's str.format() can be pretty bad. So let's say a reasonably constrained formatting language in a good runtime -- the attacker is limited in what they can see or control, and the formatter can see how many arguments were actually passed so it doesn't tromp off into other memory.
- pshc 5y agoYou are making a false equivalence—not all languages are equally busted. Any sanely designed modern language does not allow this to happen. Accidentally parsing a string you didn’t mean to parse is a fault of C’s outdated API design, a design flaw that keeps tripping people up again and again.
- junon 5y ago> Any sanely designed modern language does not allow this to happen Sorry, how does Rust protect you against injection again?
- pshc 5y agoWhy would Rust do anything weird when presented with the string "%p%s%s%s%s%n"?
- junon 5y agoWhy would C?
- pshc 5y agoDo you want the obvious explanation? Because the string was passed into the format string parameter of some sprintf-like, a common mistake in C usually caught by warnings but seemingly ignored or suppressed in this case. edit: turns out from the analysis it was CFStringCreateWithFormatAndArguments, so yes, a sprintf-like used incorrectly
- melff 5y agoIt's completely their fault either way. They are responsible for the technology they use. This nasty printf()-like way of formatting is a giant footgun though. Apple are not the first ones to fall into this trap.
- jtaft 5y agoOof. I hate to call C a mistake. I hold the language close to my heart; quirks and all. Sure there are safer models for computing. But it has served its purpose for a long time. A small language allowing highly performant programs/operating systems to be written. Plus we got to see the beautiful art form of exploit writing. Sure at what cost (lots), but all hackers can appreciate when a system gets owned. It’s the intentions that come after which bother us all. Don’t get me wrong, I’m excited for newer languages like rust to come along. However, I learned so much about low level computing from c, and I’m forever grateful. Hats off to Dennis Ritchie. Thanks for creating a language I met so many other hackers through, and sparking the curiosity of hacking within me.
- chasil 5y agoI would like to see Rust run on a PDP-8.
- throayobviousl 5y agoBut it doesn't need to, and we are talking about a modern system. C was great for its time, now its time to move on and use a sensible language.
- redis_mlc 5y ago> Yet another reason why C was a mistake. No, it allowed creation of the software at the time, when there may not have been an alternative language or environment. Having said that, it sounds like a format descriptor was misused, and if you do that badly enough, a lot of languages will misbehave.
- kwdc 5y agoAre Apple using C for this level of subsystem? I thought a lot was in Objective-C or is that just higher level stuff?
- w0mbat 5y agoApple uses C for some bits. Also there are Objective C APIs which take format strings, like +[NSString stringWithFormat:] and the system function NSLog(). Even Swift uses format strings in places. https://developer.apple.com/documentation/swift/string/3126742-init https://developer.apple.com/documentation/swift/string/31267...
- melff 5y agoC wasn't a mistake. It used to be very popular for a reason. Just like steem locomotives, they served their purpose very well in their time, but the world has moved on.