4 ms·
Is your code actually correct, efficient, and maintainable? Does the rework improve its correctness, efficiency, or maintainability? There are members of my t
by slumdev 5y ago
Is your code actually correct, efficient, and maintainable? Does the rework improve its correctness, efficiency, or maintainability?
There are members of my team whose PRs are rarely approved without rework. There are other members of my team whose PRs almost never require rework.
It's just a gut check question. This guy could be totally wrong and a jerk. Or he could be right and a jerk. If he's right and a jerk, then internalizing that feedback might help you (even if he's still a jerk.)