3 ms·
> Never assume there is a bug in your code I had a boss who went with, "Always assume the bug is in our code." Which wasn't too bad, except for the time he wou
by Jtsummers 5y ago
> Never assume there is a bug in your code
I had a boss who went with, "Always assume the bug is in our code." Which wasn't too bad, except for the time he wouldn't let us tell the hardware partner they probably had a bug until we could definitively prove that it was their problem and not ours. Took us a few months to produce a reliable test case for the error (consistent failures and not sporadic ones) and shifted the entire project schedule (not just us) right. He just didn't trust us lowly CS types.
- defaultname 5y agoThat boss' demand would be right probably 99% of time. And getting it fixed by a hardware partner without concrete evidence would be unlikely to be successful.
- Jtsummers 5y agoIt would have been right to notify the hardware partner that we believed we'd found an issue but were investigating on our end. He did not, in fact he forbade mentioning it in any meeting with them. We had good evidence that it was a hardware issue (No issue and then a new hardware revision and then the issue appeared. There had been some software changes, but none that should have impacted this). The problem was we couldn't say it with enough confidence to satisfy him, he wanted absolute proof and he did believe that CS people were incapable of identifying a hardware issue (a statement he'd made on multiple occasions). This literally resulted in spending an extra million or more to finish the project late. It was not the right call to delay several months before reporting it to the partner. It took them another 3+ months to develop a fix and we couldn't progress on the software in that time because it was not working correctly. We could make it "work" in that it would send the correct data but it was too slow to operate within the protocol specs (so the whole system would fail, hitting time limits that caused resets and test failures), or we could pray that all the correct data made it which it would 7 times out of 10. But that 30% (or more) failure rate meant that we couldn't reliably determine when a failure was in our software or the hardware.
- deleted 5y ago[deleted]
- Jemaclus 5y agoFor customer-, client-, partner-, vendor-generated complaints, I also operate on the "always assume the bug is in our code" philosophy. You don't want to go back to a customer (customer, client, partner, vendor) and tell them that it's _their_ problem until you have sufficiently ruled out evidence that it was _your_ problem. In your case above, however, I would have spent a couple of days--max--before going back to the partner and saying "Hey, we've noticed this bug, and we're still investigating things on our end, but we're reasonably confident it's not something on our end. Can you take a look?" This would have saved you months, but also demonstrated to the partner that you've done (and are doing) due diligence to investigate the problem. But for 99% of interactions, you want to assume you're the one who screwed up. It's safer and it's better customer support. A similar rule to this is to remove the phrase "it works for me" from your vocabulary. The client wouldn't be complaining about it if it worked for them! So you need to rule out a bug before you go back and say "Hey, actually, you're the one who screwed up." I've found that maybe only 50% of the time is it client error, and so I always operate under the condition that the customer was right until I can prove that they weren't.
- Jtsummers 5y agoI agree, and we'd already done that (short investigation on our end). We just hadn't fully isolated the bug, which we ended up doing after a few months once we had discovered more about the failure pattern to direct our attention to one key area of the hardware system. This let us write a single program that reliably produced the failures. But if we'd let the hardware team know early on, they may have been able to put a few days in to investigate themselves instead of waiting for us to provide them with what they should have already known (it revealed that their design and testing was grossly flawed and incomplete).