4 ms·
I got a section of Jenkins' rebuild-plugin's rebuild action for the sony ericsson. There's a spelling mistake in one of the comments, is it bad form to pull re
by Firerouge 5y ago
I got a section of Jenkins' rebuild-plugin's rebuild action for the sony ericsson.
There's a spelling mistake in one of the comments, is it bad form to pull request a one word change on a 9 year old comment?
- dylan604 5y agoyes
- chris_wot 5y agoWhy?
- dylan604 5y agoBecause it's a comment that has no bearing on how the code works. If you make another change to that same file, feel free to update the comment as well. PRs that do nothing but fix a typo in a single word in a comment are useless. Maybe if your PR has several cosmetic/docu type changes throughout once the codebase is stable and working, I could see a pass going through to clean up things like this. However, as asked, no, it is not useful.
- chris_wot 5y agoMany people dislike commits that make changes to code that has no relation to the thing being done.