3 ms·
Because when you hit a new domain on nearly every request, a pool just fills up forever with new connections. That should be fine. The pool should just start re
by pkulak 5y ago
Because when you hit a new domain on nearly every request, a pool just fills up forever with new connections. That should be fine. The pool should just start removing old connections at some point. But Go didn't do that and just filled up forever until file descriptors ran out.
- morelisp 5y agoAh, today you would set MaxIdleConns on the client to avoid this. Even back then I think there was DisableKeepAlives but I would totally believe there was a leak hiding in that ca. 2013.
- pkulak 5y agoYeah, this was forever ago, so on hindsight, maybe I shouldn't have even brought it up. haha