3 ms·
> This configuration change had been written by an authorized engineer in one team, consulting but misinterpreting vendor documentation. The change was then rev
by fuzzer37 5y ago
> This configuration change had been written by an authorized engineer in one team, consulting but misinterpreting vendor documentation. The change was then reviewed by three other authorized engineers in three separate teams, according to normal processes. None of them spotted the mistake in the configuration update.
Is anyone else shocked by this? Are code reviews worthless? An engineer made a change reviewed by 3 other people. It seems like _someone_ would notice.
- peach 5y agoOnce in a while a bunch of people will fail to notice something that might be cryptic if you don't know the details.
- coldcode 5y agoReviewing someone's code you had not seen before, involving a third party vendor you know nothing about, that only happens in production environment and only randomly fails and otherwise works—does not shock me at all. No process no matter how thorough can still fail. Code reviews in my prior experience solved nothing as people were expected to work full time and yet still review code continuously; unless you give engineers sufficient time to do both without overtime effort, one or the other will be affected, and usually its the reviews.
- mdaniel 5y agoI had always seen code review process as partially a knowledge sharing exercise, so fine, maybe none of the 3 other engineers had previously seen those vendor docs, but part of the process is to retrace the steps and see if (with the benefit of hindsight) the reviewer would reach the same conclusion > Code reviews in my prior experience solved nothing I find that assertion suspicious, unless the culture was "push the approval button without even reading because ship,ship,ship"