3 ms·
> And many tech leads simply don't have the time to review every single WIP commit Do you usually review every commit? I usually just review the diff between t
by user-the-name 5y ago
> And many tech leads simply don't have the time to review every single WIP commit
Do you usually review every commit? I usually just review the diff between the PR'd branch and master, as does everyone I work with.
- pdimitar 5y agoExactly, and that's why we use squashed commits.
- user-the-name 5y agoWhy? You don't need to. GitHub will show you that diff, git itself will show you that diff. There is no need to permanently rewrite history to do this. That makes no sense.
- pdimitar 5y agoFor the last time: squashed commits help teams who need the main branch be a high-level history of delivered features and fixed bugs. Where one commit is one delivered feature or a bug fixed. That's the idea. Whether you think that "makes no sense" is inconsequential. Many people find it very meaningful.