3 ms·
> For the next 6 months, I spent my extra hours before class (and during my least favorite classes) working on Rails bug reports... The core team members held e
by jrochkind1 5y ago
> For the next 6 months, I spent my extra hours before class (and during my least favorite classes) working on Rails bug reports... The core team members held every pull request to a very high standard, and I learned a lot about how to write good code.
My question is how he got anyone from rails core team to review his PR's! Maybe things were different then.
- johnjwang 5y agoAuthor here: I started by making really small patches at the beginning and building up credibility with the team. For example, one of my earliest commits was just to add better verbiage on migrations (https://github.com/rails/rails/commit/b4c99ea0a4d7e5223fa1b21cdb9301f9d090dbfe https://github.com/rails/rails/commit/b4c99ea0a4d7e5223fa1b2...). Eventually the core team saw my name enough that my pull requests could get more complex.