3 ms·
I thought about writing "patches are welcome" as an example response, and I deliberately chose, "I'm sorry, but I just don't have time for that," instead. Revie
by quanticle 5y ago
I thought about writing "patches are welcome" as an example response, and I deliberately chose, "I'm sorry, but I just don't have time for that," instead. Reviewing a patch, in many cases, takes somewhere between 50% and 75% of the time it takes to write the code in the first place. It's not a given that someone who open sourced a random project will have time to review patches.
- kop316 5y agoPersonally, I much prefer "patches are welcome". It puts the ownership back on that person who asked for XYZ feature to do it. If that person is actually motivated enough to write a patch (which I have had!), I welcome reviewing it, because it empowers that person to feel like they can contribute to my project (and hopefully other projects too!), and makes others feel like they can contribute to my project as well.
- lupire 5y agoPatches are always welcome on your fork. Upstream can merge whenever they want.
- meetups323 5y agoHah. I regularly see patches whose review takes well over 100% the time it would have taken me to create the patch myself. But then I'm employed by $MEGA_CORP and part of the job description is "helping to build and maintain the OSS community", so helping novices create their first patches is a big part of that.