3 ms·
You can always commit it to your home share but no, at Google all code that is checked in to version control must be reviewed, period.
by Locke1689 15y ago
You can always commit it to your home share but no, at Google all code that is checked in to version control must be reviewed, period.
- bsergean 15y agoWhat does commit to your home share means in term of perforce ? cp .cc .h /tmp/backup ?
- FaceKicker 15y agoThe exception being the "experimental" part of the code base, which can never be used in any production code without undergoing a full code review.
- gte910h 15y agoSo you can commit it somewhere. You just can't commit it to a certain repo.
- lpolovets 15y agoIt's more like without a code review you can only commit to your personal scratch space. A more accurate way to state "At Google, no code, for any product, for any project, gets checked in until it gets a positive review" would be that "No code goes into production without a positive code review."
- gte910h 15y agoWhich is completely reasonable. The original contention of no checkins at all sounds like hell.
- guelo 15y agoThe original statement makes sense if they are not using a DVCS (I know that at least a couple years ago they were mostly a Perforce shop). If they are now using a DVCS then they probably have repos for different code stages plus all the local repos.