3 ms·
Most of it is header files full of redundant register names. It's pretty ridiculous. The driver code itself also has lots of code duplication. It's just strang
by atq2119 5y ago
Most of it is header files full of redundant register names. It's pretty ridiculous.
The driver code itself also has lots of code duplication. It's just strange.
- vbezhenar 5y agoWhat's strange is why Linus allows that kind of code in the kernel.
- ClumsyPilot 5y agoBecause done is better than perfect. I've had enough issues with ideologues precenting any meaning full progress
- snuxoll 5y agoIt’s also not the worst way of making sure new chips get supported relatively quickly. Those “giant” header files are mechanically generated from the RTL source for each GPU, it’s not like it’s some horrendously inefficient bloat form an outsource developer that doesn’t care about writing clean code or something.
- samus 5y agoI think there are three reasons why overall this is not that bad for the Linux code base: - it is a driver, not a core module - the constants are implementation details of the driver - active maintenance of code is a necessary condition for inclusion in the Kernel. The other Kernel developers are not supposed to maintain and refactor code dumps.