6 ms·
Yeah, that default ruleset is quite sparse. It would be nice to see Go's Code Review Comments (https://github.com/golang/go/wiki/CodeReviewComments https://gith
by jidiculous 5y ago
Yeah, that default ruleset is quite sparse. It would be nice to see Go's Code Review Comments (https://github.com/golang/go/wiki/CodeReviewComments https://github.com/golang/go/wiki/CodeReviewComments) added as a basic ruleset.
- leetrout 5y agoThat is a really great idea. I love that wiki page. Some of them are harder to follow in a team that prefers "expressiveness". Quotes because I think it's easier to follow Go's prescription especially for always returning concrete types instead of interfaces. > return a concrete type and let the consumer mock the producer implementation
- komuW 5y agoI usually use Damian Gryski's: https://github.com/dgryski/semgrep-go https://github.com/dgryski/semgrep-go