4 ms·

This is a good example of a pointless alignment footguns tabs prevented. Why do you want to recalculate the number of spaces before 'that' based on any change

This is a good example of a pointless alignment footguns tabs prevented. Why do you want to recalculate the number of spaces before 'that' based on any change to the length of the function name 'connect', and why do you realize you don't want to when it comes to aligning connect with 'foo' to be consistent with this styling instead of indenting priority? Much easier to hit tab twice on the 3rd line because that is the correct nesting depth and not try to adapt lines based on insignificant aspects of previous lines and not make someone refactoring try to hop around any more than necessary. Edit-typos

jcelerier 5y ago
> Why do you want to recalculate the number of spaces before 'that' based on any change to the length of the function name 'connect' from experience ? connect is a Qt function that dates back to 1995, it's been here for the last 30 years, it'll be there when I retire. Optimizing my experience for "what if connect was renamed" is a big YAGNI. > , and why do you realize you don't want to when it comes to aligning connect with 'foo' to be consistent with this styling instead of indenting priority? I don't understand what you mean there, what would "aligning connect with foo" mean ?
- foolmeonce 5y ago
  > from experience ? Then that's a bad example since this alignment with preceding line style commits you irregardless of your history with any function. > I don't understand what you mean there, what would "aligning connect with foo" mean ? If you are aligning with lines above you and your coworkers have so many options: void foo(.. connect(.. int foo(.. connect(.. int foo(..) { connect( If you are nesting with fixed indents, then everything is fairly well defined and simple changes to one line don't cause significant reflow.

jcelerier 5y ago

> Why do you want to recalculate the number of spaces before 'that' based on any change to the length of the function name 'connect' from experience ? connect is a Qt function that dates back to 1995, it's been here for the last 30 years, it'll be there when I retire. Optimizing my experience for "what if connect was renamed" is a big YAGNI. > , and why do you realize you don't want to when it comes to aligning connect with 'foo' to be consistent with this styling instead of indenting priority? I don't understand what you mean there, what would "aligning connect with foo" mean ?

foolmeonce 5y ago
> from experience ? Then that's a bad example since this alignment with preceding line style commits you irregardless of your history with any function. > I don't understand what you mean there, what would "aligning connect with foo" mean ? If you are aligning with lines above you and your coworkers have so many options: void foo(.. connect(.. int foo(.. connect(.. int foo(..) { connect( If you are nesting with fixed indents, then everything is fairly well defined and simple changes to one line don't cause significant reflow.