4 ms·

This is really cool stuff, we're at Pyroscope [1] would love to add support for it. Too bad it's a fork of Go runtime. As @akshayshah mentioned, it seems like

This is really cool stuff, we're at Pyroscope [1] would love to add support for it. Too bad it's a fork of Go runtime. As @akshayshah mentioned, it seems like Go team is hesitant about straight up merging this. I wonder if a better approach would be to open up Go runtime apis so that this can be a module instead of a whole fork. I think opening up these APIs would also enable more innovation in profiling space. [1]: https://github.com/pyroscope-io/pyroscope https://github.com/pyroscope-io/pyroscope

rob74 5y ago
"Modularizing" the runtime sounds like a good idea, but also adds new constraints: they would have to document the interfaces between the various modules and then either keep them unchanged, which would hinder further development; or if they change the module interfaces, the modules will have to be updated nevertheless, so having modules won't be much of an advantage...