3 ms·
> Rather than linting before pushing, I enjoy waiting for Hound's comments and fixing them afterward. That's a poor practice, IMO. A PR should mean that code
by mytailorisrich 6y ago
> Rather than linting before pushing, I enjoy waiting for Hound's comments and fixing them afterward.
That's a poor practice, IMO.
A PR should mean that code is ready to merge, so it must have been linted and tested beforehand, so I agree with Director of Eng that there should be little chatter.
This probably goes hand in hand with your practice of opening "draft PR".
Now, if Hound is only accessible to you that way and you think it is a valuable tool to use before opening a PR then this may be a worthwhile discussion to have with him.
- ciisforsuckas 6y agoyes and this is why a lot of us have started runnning CI on PR's and failing PR's if they don't pass basic quality gateways like linting.