4 ms·
I've seen this scenario happen at other companies too. I think this is where a code review process helps. You can submit changes, but you have to work with the
by mateo411 5y ago
I've seen this scenario happen at other companies too.
I think this is where a code review process helps. You can submit changes, but you have to work with the team to review them. This way they have buy in on the changes that you make. You'll find developers can get upset if changes were made and they weren't aware of them. In addition to ensuring the code is of high quality, code review also acts as a medium to communicate changes within the team.
- phibz 5y agoCode review is not enough. Especially when you're dealing with a culture of "rubber stamped reviews." Good code reviews are a net positive but may not always be in place. Getting them on a team that isn't doing them is yet another point where you need to communicate with them. You've got to talk, whiteboard, engage much sooner.