3 ms·

I got it to work with the following but errored out on openssl so I couldn't install pip. It builds fine with docker fedora 32. Thank you. Platform Fedora 32,

I got it to work with the following but errored out on openssl so I couldn't install pip. It builds fine with docker fedora 32. Thank you. Platform Fedora 32, Docker on Windows 10, Version 2004 Steps to Reproduce Install docker from docker.com docker run -t -i fedora:32 bash git clone https://github.com/facebookincubator/cinder.git yum install zlib-devel openssl-devel ./configure make make altinstall This error is occurs when you do ./configure --enable-optimizations this version of python complies it either way. >> Objects/accu.o Parser/listnode.c: In function ‘list1node’: Parser/listnode.c:66:1: error: ‘/cinder/Parser/listnode.gcda’ profile count data file not found [-Werror=missing-profile] 66 | } | ^ If you get this error it is because you used --enable-optimizations. github.com/brianherman https://www.linkedin.com/in/brian-herman-092919208/ https://www.linkedin.com/in/brian-herman-092919208/ Edit: Removing github flavored markdown Edit: Answering own question Edit: More formatting

wheybags 5y ago
Pet peeve: people who put Werror in the default build flags. Leave it off by default, turn it on in your ci!
- nitrogen 5y ago
  For me, I'd rather get a bug report about a failure during compilation, than something more obscure and harder to find at runtime.
  - simfoo 5y ago
    The parent proposed gating for warnings in the CI, not (by default) on the developer build. I completely agree with this, as a dev I want to see warnings but I don't always want to have everything perfect from the start. The famous example here is -Wunused-arg. I DON'T want to fight this during development, when I often have prototyping stages where functions remain unimplemented intentionally. I very much want to avoid merging this into master though, so CI gating with -Werror it is.
    - wheybags 5y ago
      Also "I'm trying to build your code 5 years later with a version of GCC which has a load of new warnings you'd never seen". Dealing with those is not my problem, I just want to run your tool.

wheybags 5y ago

Pet peeve: people who put Werror in the default build flags. Leave it off by default, turn it on in your ci!

nitrogen 5y ago
For me, I'd rather get a bug report about a failure during compilation, than something more obscure and harder to find at runtime.
- simfoo 5y ago
  The parent proposed gating for warnings in the CI, not (by default) on the developer build. I completely agree with this, as a dev I want to see warnings but I don't always want to have everything perfect from the start. The famous example here is -Wunused-arg. I DON'T want to fight this during development, when I often have prototyping stages where functions remain unimplemented intentionally. I very much want to avoid merging this into master though, so CI gating with -Werror it is.
  - wheybags 5y ago
    Also "I'm trying to build your code 5 years later with a version of GCC which has a load of new warnings you'd never seen". Dealing with those is not my problem, I just want to run your tool.