3 ms·
I think https://news.ycombinator.com/item?id=26925235 https://news.ycombinator.com/item?id=26925235 put it nicely. PRs are expensive. So when you think 'this i
by codesuki 5y ago
I think https://news.ycombinator.com/item?id=26925235 https://news.ycombinator.com/item?id=26925235 put it nicely.
PRs are expensive. So when you think 'this is a self contained change, but I need it to continue development' you are unlikely to send a PR for it. You will just pile on more code.
Because if you make another PR based on that first PR and someone finally does code review and tells you to fix something then you suddenly need to propagate these changes to all follow up PRs which is quite some work.
And while I think I might just miss something obvious it seems many people miss it that's why we have blog posts about 'stacked PRs'. (On HN a day ago or so)