4 ms·
I'm still reading the article, but it looks like there's a typo where it refers to: Merge in the stack from top to bottom - in this case we're going to
by jasonpeacock 6y ago
I'm still reading the article, but it looks like there's a typo where it refers to:
Merge in the stack from top to bottom - in this case we're
going to merge Feature 3's PR, Feature 2's PR, and Feature
1's PR, in that order, using GitHub's UI.
But the "top to bottom" would be merging F1, then F2, then F3 (and you'd have to rebase & re-upstream each as you go).
- tta 6y agoThis is good feedback, thank you! I intend "top" to mean "the PR furthest from `master`" and "bottom" to mean "the PR closest to `master`". I'll add a section clarifying this nomenclature.
- jasonpeacock 6y agoMy confusion comes from the associated image, where the top of the list is F1, and the bottom of list is F3. Maybe a new image of the branches with the list order reversed?