3 ms·
GitHub Actions update: Helping maintainers combat bad actors Keyword helping. How is this helping maintainers, exactly? Forcing them to perform manual steps or
by nathanaldensr 6y ago
GitHub Actions update: Helping maintainers combat bad actors
Keyword helping. How is this helping maintainers, exactly? Forcing them to perform manual steps or else is not helping. This is pure PR spin.
- ncallaway 6y ago> Forcing them to perform manual steps or else is not helping I don't see the "forcing" or the "or else" in the github blog post. Can you explain how github is forcing them to perform a manual step? Or, can you explain what the consequence of them not performing the manual step of approving the PR is?
- Gaelan 6y agoPreviously, PRs would automatically cause actions to be run, for all users. So users could notice and fix CI failures themselves, and maintainers could see that CI was passing they first looked at the PR. The maintainer needs to touch the PR a minimum of once: look at the code, see CI passes, merge. Now, the maintainer has to look at the code and approve, at which point they have to wait for CI to pass, then come back later and merge; or, if CI fails, come back and re-approve each time the contributor tries to fix it, so a minimum of two times, and quite possibly more if there are CI failures (which, I expect, is common for first-time contributions).
- deleted 6y ago[deleted]