5 ms·

Where does it say in the discussion that it was accepted? Someone suggested that it be done, and most seem to be against and no conclusion has been reached at

Where does it say in the discussion that it was accepted? Someone suggested that it be done, and most seem to be against and no conclusion has been reached at the bottom, as far as I can tell.

tosh 6y ago
Gargron is the lead developer of Mastodon
- Arnavion 6y ago
  That doesn't mean the PR is guaranteed to be merged, let alone already merged, as the submission title implies.
  - tosh 6y ago
    it doesn't, I added the comment for context in case other readers are not aware (@ "someone")
    - tosh 6y ago
      update: merged
xiaq 6y ago
AFAICT the PR author is actually the #1 developer of Mastodon and also authored the original change of renaming "posts" to "toots".
kgwxd 6y ago
It shows "Changes Approved" at the bottom. I've never done any collaboration work on github, does that mean it's happening?
- ufo 6y ago
  It means that another mastodon developer (ykzts) reviewed and approved the code. However, the commits haven't been merged to the main branch yet.
- detaro 6y ago
  no, that just means someone has given approval. The more relevant bit to "will this be merged" is that Gargron is pretty much the BDFL of Mastodon.
deleted 6y ago
[deleted]
FalconSensei 6y ago
Mastodon is open source, but Gargron 'owns' it and does most of the dev. He does what he wants, and he approves or not what other people want to do