3 ms·

The latter change introduces an unnecessary clone(). The correct approach is to instead introduce a variable so that headerRegex can keep being a reference to e

by devit 5y ago

The latter change introduces an unnecessary clone(). The correct approach is to instead introduce a variable so that headerRegex can keep being a reference to either that variable or to HEADER_REGEX.

ahelwer 5y ago
Can you expand on how this stops a clone from happening?
- devit 5y ago
  If you don't call clone() then a clone doesn't happen...
  - ahelwer 5y ago
    Ah, I didn't see the extra clone. I thought it was something to do with that additional variable you defined. I guess you need to do that or else you have to do a clone.