4 ms·
I agree that you shouldn't be doing this stuff in production if you don't know the ends and outs of doing this idiomatically. For instance, the lack of parenth
by monocasa 6y ago
I agree that you shouldn't be doing this stuff in production if you don't know the ends and outs of doing this idiomatically. For instance, the lack of parenthesis ala
#define SQ(x) ((x)*(x))
set off my C spidey senses. I use them even for constants in pound defines just to be consistent.
That being said, there are benefits, like the type safety listed being one of them. No weird cast to void* and go to town on raw memory shenanigans you would have to do to use functions in intrusive collections in C.
- mgerdts 6y agoYou mean: #define SQ(x) ((x)*(x))
- deleted 6y ago[deleted]
- monocasa 6y agoYeah, thanks. That's what I get for trying to type code on my phone.
- throwaway3neu94 6y agoThere's another pitfall: it evaluates a parameter twice. Imagine calling SQ(func_with_side_effects()). If you can assume a compiler with statement expressions and typeof (gcc, clang, probably icc in this case): #define SQ(x) ({ typeof(x) x_ = (x); x_ * x_ }) If not (MSVC++) then best of luck. Anyway I 100% agree people way, way overuse macros. Very often a static inline function is a better trade-off.