3 ms·
Noticed the same too. It is likely that we are both impacted by the very aggressive default of 1ms for `internal_poll_interval`: https://github.com/ceph/ceph-cm
by throwdbaaway 6y ago
Noticed the same too. It is likely that we are both impacted by the very aggressive default of 1ms for `internal_poll_interval`: https://github.com/ceph/ceph-cm-ansible/pull/308 https://github.com/ceph/ceph-cm-ansible/pull/308
- nullify88 6y agoThanks for the heads up, i'll give that a go :)
- mkj 6y agoHuh, polling with a sleep() rather than a proper event wait seems like a bad code smell there...
- necheffa 6y agoHow so? This is almost certainly what the internals of a packaged event wait would look like.
- mkj 6y agoIt could use a Queue of some kind rather than just pushing onto a deque between threads [1]? Then it would idly wait for the results_thread_main to push results. I guess that might be what Mitogen does (along with other improvements), a faster Ansible strategy [2]. [1] https://github.com/ansible/ansible/blob/becf9416736dc911d3411b92f09512b4dae2955c/lib/ansible/plugins/strategy/__init__.py#L109 https://github.com/ansible/ansible/blob/becf9416736dc911d341... [2] https://github.com/mitogen-hq/mitogen/blob/master/docs/ansible_detailed.rst https://github.com/mitogen-hq/mitogen/blob/master/docs/ansib...