4 ms·
It looks like you have a wrong metric for the productivity. A lot of projects failed just because developers created millions lines of code. The performant dev
by drran 6y ago
It looks like you have a wrong metric for the productivity. A lot of projects failed just because developers created millions lines of code.
The performant developer solves problems quickly, without creating problems for others, i.e. he unloads burden from the project.
- lanstin 6y agoSeriously. We have hired a lot of people recently and the people that submit a five line PR make me happy and the fifteen file PRs make me sad.
- randomswede 6y agoI have slowly managed to train my colleagues that a PR should be "one thing". My team ends up doing a whole lot of internal tooling, so we're frequently creating "new small tool" and one colleague started by working away and only raising the PR when the toll was essentially done. This, essentially, ends up with a PR review that takes hours to complete, only to end up with at least a few "changes required". Leading to updates, and a re-review, usually with enough time lapsed that the review ends up being "from scratch" (partially due to the size of the PR, partially due to the time lapsed). We've now mostly converged to "start with a PR just setting the skeleton up and one testable function", meaning that what used to be a single monster PR now ends up as 5-15 PRs, each one much easier to review. Amusingly, this also tends to end up with things being completed faster.